Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should unused span cover type annotation as well #24598

Closed
mjbvz opened this issue Jun 1, 2018 · 2 comments
Closed

Should unused span cover type annotation as well #24598

mjbvz opened this issue Jun 1, 2018 · 2 comments
Labels
Working as Intended The behavior described is the intended behavior; this is not a bug

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jun 1, 2018

From microsoft/vscode#50640

TypeScript Version: 3.0.0-dev.201601

Search Terms:

  • unused

Code

function foo(x: number) {}

Current behavior:
Only the span for the letter x is marked as unused

Question
Should the unused span cover the type annotation as well

@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Jun 1, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jun 2, 2018

Given our previous attempts to mark the keyword as part of the span, i think we are better off just marking the declaration name consistently.. see #24573 for more details.

@mhegazy mhegazy added Working as Intended The behavior described is the intended behavior; this is not a bug and removed VS Code Tracked There is a VS Code equivalent to this issue labels Jun 2, 2018
@typescript-bot
Copy link
Collaborator

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Working as Intended The behavior described is the intended behavior; this is not a bug
Projects
None yet
Development

No branches or pull requests

3 participants