call hierarchy shows full file paths

[jrieken]

TS Template added by @mjbvz

TypeScript Version: 3.8.0-dev.20200128

Search Terms

• call hierarchy
• provideCallHierarchyIncomingCalls

/cc @rbuckton

---

re microsoft/vscode#89386

• use ts3.8-beta
• show callers of mergeSort
• 🐛 some entries show as full file paths, instead they should be folder/project relative

[mjbvz]

Here's the response that causes this:

Trace  - 19:46:11.735] <semantic> Response received: provideCallHierarchyIncomingCalls (138). Request took 120 ms. Success: true 
Result: [
    {
        "from": {
            "name": "/Users/matb/projects/vscode/src/vs/base/test/common/arrays.test.ts",
            "kind": "module",
            "file": "/Users/matb/projects/vscode/src/vs/base/test/common/arrays.test.ts",
            "span": {
                "start": {
                    "line": 1,
                    "offset": 1
                },
                "end": {
                    "line": 347,
                    "offset": 1
                }
            },
            "selectionSpan": {
                "start": {
                    "line": 1,
                    "offset": 1
                },
                "end": {
                    "line": 1,
                    "offset": 1
                }
            }
        },
        "fromSpans": [
            {
                "start": {
                    "line": 49,
                    "offset": 53
                },
                "end": {
                    "line": 49,
                    "offset": 62
                }
            },
            {
                "start": {
                    "line": 55,
                    "offset": 36
                },
                "end": {
                    "line": 56,
                    "offset": 1
                }
            },
            {
                "start": {
                    "line": 68,
                    "offset": 31
                },
                "end": {
                    "line": 68,
                    "offset": 40
                }
            },
            {
                "start": {
                    "line": 70,
                    "offset": 30
                },
                "end": {
                    "line": 70,
                    "offset": 39
                }
            },
            {
                "start": {
                    "line": 99,
                    "offset": 64
                },
                "end": {
                    "line": 99,
                    "offset": 73
                }
            }
        ]
    },
    ...

[rbuckton]

@jrieken, @mjbvz: Isn't this supposed to be handled by asRelativePath here: https://github.com/microsoft/vscode/blob/d91ca067cab6a9a52ba07feb50c9c800d0891552/extensions/typescript-language-features/src/features/callHierarchy.ts#L79-L81?

[rbuckton]

Related discussion: #31863 (comment)

[jrieken]

Yeah, should be... Unsure if the file doesn't match the workspace path because of "path formatting" issues?

[mjbvz]

Fixed for me in the current VS code code base using TS 3.9-nightly

@jrieken Do you still see this issue?

[rbuckton]

@jrieken, @mjbvz has there been any further investigation on the VSCode side? I haven't been able to repro this on Windows. Was the original case discovered on an *nix operating system?

[andrewbranch]

Doesn’t repro for me on macOS either. The original screenshot was taken on macOS. Seems like this is fixed.