Duplicate entries for call hierarchy

[jrieken]

TS Template added by @mjbvz

Test TypeScript Version: 3.8.0-dev.20200128

Search Terms

• Call hierarchy
• provideCallHierarchyOutgoingCalls

/cc @rbuckton

---

re microsoft/vscode#89386

• us ts3.8-beta
• show calls from here resolve
• split is shown two time

[mjbvz]

Here are the duplicated response objects:

    {
        "to": {
            "name": "split",
            "kind": "method",
            "file": "/Users/matb/projects/vscode/node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts",
            "span": {
                "start": {
                    "line": 255,
                    "offset": 5
                },
                "end": {
                    "line": 260,
                    "offset": 110
                }
            },
            "selectionSpan": {
                "start": {
                    "line": 260,
                    "offset": 5
                },
                "end": {
                    "line": 260,
                    "offset": 10
                }
            }
        },
        "fromSpans": [
            {
                "start": {
                    "line": 201,
                    "offset": 18
                },
                "end": {
                    "line": 201,
                    "offset": 37
                }
            },
            {
                "start": {
                    "line": 201,
                    "offset": 18
                },
                "end": {
                    "line": 201,
                    "offset": 37
                }
            },
            {
                "start": {
                    "line": 201,
                    "offset": 18
                },
                "end": {
                    "line": 201,
                    "offset": 37
                }
            },
            {
                "start": {
                    "line": 201,
                    "offset": 18
                },
                "end": {
                    "line": 201,
                    "offset": 37
                }
            }
        ]
    },
    {
        "to": {
            "name": "split",
            "kind": "method",
            "file": "/Users/matb/projects/vscode/node_modules/typescript/lib/lib.es5.d.ts",
            "span": {
                "start": {
                    "line": 470,
                    "offset": 5
                },
                "end": {
                    "line": 475,
                    "offset": 65
                }
            },
            "selectionSpan": {
                "start": {
                    "line": 475,
                    "offset": 5
                },
                "end": {
                    "line": 475,
                    "offset": 10
                }
            }
        },
        "fromSpans": [
            {
                "start": {
                    "line": 201,
                    "offset": 18
                },
                "end": {
                    "line": 201,
                    "offset": 37
                }
            },
            {
                "start": {
                    "line": 201,
                    "offset": 18
                },
                "end": {
                    "line": 201,
                    "offset": 37
                }
            },
            {
                "start": {
                    "line": 201,
                    "offset": 18
                },
                "end": {
                    "line": 201,
                    "offset": 37
                }
            },
            {
                "start": {
                    "line": 201,
                    "offset": 18
                },
                "end": {
                    "line": 201,
                    "offset": 37
                }
            }
        ]
    },

[rbuckton]

We discussed this during the implementation and explicitly made the decision to support multiple results from call hierarchies for this express case (multiple declarations of the reference across multiple files): #31863 (comment)

I think I'd classify this as "working as intended"

[jrieken]

I think without context information (containing symbol, filename, etc) this pretty useless. How would I know what to click when seeing "split" and "split"?

[mjbvz]

@jrieken Does #37061 cover that?

[jrieken]

Yeah, just not sure if that ever happens. In the meantime we can force the filename to show when there is no detail