-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple tsconfig.json files in ASP.NET v5 projects #4714
Comments
Will this allow me to have my tsconfig.json in some other location? Currently, our structure has all of our typescript files in /projectroot/client; naturally I created my tsconfig file in that directory originally. |
@mjohnsonengr Yes, that will work for 1.8, further for 1.7 we made a small change to allow the 1.7 is part of Visual Studio 2015 Update 1 (currently available as an RC). |
@paulvanbrenk curious what will happen if we have a |
Yep, that will give 2 errors.. similar to what happens when you use 'linked files' in C# projects. And you do want two errors, since they are potentially in a different context (e.g. es3, and es5)... the effort to filter out true duplicates is probably not worth it. |
Completely agree 🌹 👍 |
What is the status on this issue? Release date yet known? |
Still planned for 1.8, no concrete date yet. |
Should be fixed in TS 1.8 |
Is this actually fixed in 1.8? And is it specifically limited to the ASP.NET v5 project type? I'm using a C# console app with the old .targets manually added but visual studio complains about duplicate definitions and does not seem to be honoring either of my tsconfig.json files' output settings. (This is for an Electron project that I'm trying to organize and basing it on an ASP.NET web project with a web server and so on is unnecessary overhead. I'm struggling to get a really clean setup going for this in Visual Studio. Preferably I wouldn't have to involve .NET-branded things in this particular project at all but I'm not aware of a way to have a full dev workflow in VS without hacking the C# or VB project types.) |
@MrAndMrsK can you share your project, and/or a build log (msbuild /v:detailed)? |
also what version of TS are you using in VS? |
@MrAndMrsK for a Console App, I would recommend using the NuGet package to get the best experience. https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild/ |
@paulvanbrenk - Cool, that's good to know but it didn't fix the problem. @mhegazy - I already updated my PATH to 1.8 (which I keep having to do manually??) and rebooted. Visual Studio was already using 1.8, yes, and now with the suggested NuGet package I can see the Here's the project structure, with the newly placed/refreshed files output in the wrong place: Contents of one of the two similar .tsconfig files:
And the build log: |
…definitions because currently github-electron-renderer.d.ts and github-electron-main.d.ts can't be used with tsd.d.ts at the same time. tsd.d.ts includes both definition files. So I unite them to resolve it.
the log indicates that there were no config files, so obviously something went wrong there. can you verify that the content type of your tsconifig.json is "Content", and can you share a sample project? |
also can you file a different issue. |
Ok, they weren't "Content", so I corrected that. After that it seems like If you think there's a bug here, please let me know what it is and I'll be happy to file it. The situation was confusing to me, but I'm not sure how to describe that as a bug. |
@MrAndMrsK this is actually a new feature. module outputs are concatenated using --outFile. i am assuming you are using module.. is that correct? For more details please see: https://github.com/Microsoft/TypeScript/wiki/What%27s-new-in-TypeScript#concatenate-amd-and-system-modules-with---outfile |
Yes, but the outDir is not being honored. I had:
"combinedOut.js" was being generated, but it wasn't being put in ../built. This works though:
|
aah.. they do not combine. actually it should be an error to specify outFile and outDir in conjunction. this is tracked bu #3305 |
As I understand this feature is named Virtual Project ? |
We want to enable the ability to have more than 1
tsconfig.json
file in an asp.net v5 project, this will make the compilation of ts files more flexible.See these comments:
#4161 (comment)
#4161 (comment)
The text was updated successfully, but these errors were encountered: