Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS merge quickinfo is inconsistent #48197

Open
weswigham opened this issue Mar 10, 2022 · 0 comments
Open

JS merge quickinfo is inconsistent #48197

weswigham opened this issue Mar 10, 2022 · 0 comments
Labels
Bug A bug in TypeScript checkJs Relates to checking JavaScript using TypeScript Domain: JavaScript The issue relates to JavaScript specifically Domain: Quick Info e.g. hover text, tool-tips, and tooltips.
Milestone

Comments

@weswigham
Copy link
Member

Given this playground,

module.exports = class C {}
module.exports.fn = function() {}

quick info display on hover of class C depends on if you hover module.exports first or not. If you hover module.exports first, it's

(local class) C
module C

if you hover class C first, without hovering anything else, it's

(local class) C

The first - the version with module C - is the correct one. In the later case, we fail to merge the module and class symbols.

@weswigham weswigham added Bug A bug in TypeScript checkJs Relates to checking JavaScript using TypeScript labels Mar 10, 2022
@DanielRosenwasser DanielRosenwasser added Domain: Quick Info e.g. hover text, tool-tips, and tooltips. Domain: JavaScript The issue relates to JavaScript specifically labels Mar 11, 2022
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript checkJs Relates to checking JavaScript using TypeScript Domain: JavaScript The issue relates to JavaScript specifically Domain: Quick Info e.g. hover text, tool-tips, and tooltips.
Projects
None yet
Development

No branches or pull requests

3 participants