Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting honours tab vs spaces setting only sometimes? #6667

Closed
egamma opened this issue Jan 27, 2016 · 3 comments
Closed

Formatting honours tab vs spaces setting only sometimes? #6667

egamma opened this issue Jan 27, 2016 · 3 comments
Assignees
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created

Comments

@egamma
Copy link
Member

egamma commented Jan 27, 2016

From @alexandrudima on January 27, 2016 13:6

Testing #2218

I have the following settings:

// Place your settings in this file to overwrite default and user settings.
{
    "typescript.tsdk": "C:\\Alex\\salsa\\node_modules\\typescript\\lib",
    "editor.tabSize": 4,
    "editor.insertSpaces": false
}

If I have a function indented with 5 spaces, and choose format, the 5 spaces get replaced with a tab:

function howdyAgain(name) {
     return 'hi';
}

If I have the same function indented with 4 spaces, and choose format, the 4 spaces do not get replaced with a tab:

function howdyAgain(name) {
    return 'hi';
}

Copied from original issue: microsoft/vscode#2443

@billti
Copy link
Member

billti commented Jan 27, 2016

@zhengbli @vladima Any idea what's going on here? Do we see the same problem in TypeScript code?

@zhengbli
Copy link
Contributor

I saw this problem on .ts files too.

@billti billti added Bug A bug in TypeScript and removed Salsa labels Jan 28, 2016
@billti billti modified the milestones: Salsa 0.9, TypeScript 2.0 Jan 28, 2016
@billti billti changed the title Salsa formatting honours tab vs spaces setting only sometimes? Formatting honours tab vs spaces setting only sometimes? Jan 28, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Feb 24, 2016

duplicate of #2306

@mhegazy mhegazy closed this as completed Feb 24, 2016
@mhegazy mhegazy added the Duplicate An existing issue was already created label Feb 24, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

4 participants