Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document.getElementsByName should return NodeListOf<HTMLElement> #7709

Closed
FranklinWhale opened this issue Mar 28, 2016 · 0 comments
Closed

document.getElementsByName should return NodeListOf<HTMLElement> #7709

FranklinWhale opened this issue Mar 28, 2016 · 0 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 2.0

Comments

@FranklinWhale
Copy link

According to the HTML Specification, document.getElementsByName applies only to HTML elements that have a name attribute, unlike document.getElementById, document.getElementsByTagName and document.getElementsByClassName which are defined in the core DOM specification. Therefore, document.getElementsByName should return NodeListOf<HTMLElement> instead of NodeListOf<Element>.

TypeScript Version:

1.8.5
This was referenced Mar 28, 2016
Merged
Closed
@mhegazy mhegazy added Bug A bug in TypeScript Help Wanted You can do this Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript labels Mar 28, 2016
@mhegazy mhegazy added this to the Community milestone Mar 28, 2016
@zhengbli zhengbli mentioned this issue Apr 27, 2016
Merged
@mhegazy mhegazy modified the milestones: TypeScript 2.0, Community Apr 27, 2016
@zhengbli zhengbli added Fixed A PR has been merged for this issue and removed Fixed in TSJS repo labels Apr 27, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 2.0
Development

No branches or pull requests
3 participants
@zhengbli @mhegazy @FranklinWhale