-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom domains settings drop after each deployment #1243
Comments
@relounge thank you for raising this with us. Could you share the repo or Bicep you're using. The issue may need updating of the boilerplate Bicep to include the custom domain. |
Please see here for guidance on how you can add the custom domain to your Bicep file (found in |
@simonjj sorry, I cannot share the repo as it's our production repo. As for the Bicep file - I did not have it until you mentioned it. I deployed our aspire app using the instructions I found in the MS documentation and used this file as a workflow file for Github actions. |
I don't get it. All of the examples here are in Bicep/JSON or Terraform syntax, but the files generated for containerized services by "synth" command were yaml files. This adds a bit of complexity. Will try to guess how it works |
So I:
Here is how I changed the service yaml file: I think I need some help. We choose Aspire to get rid of docker files hell. Now I see we got bicep and yaml hell instead. |
Found a solution for custom domains from here Azure/azure-dev#1765 Removed everything about costom domains from yaml files and set ingress external to true. It seems to be working now. I didn't have to do any manula settings after the latest deployment. |
thanks for updating us @relounge. i will share your feedback with the appropriate teams. |
This issue is a: (mark with an x)
Issue description
We're trying to work with .NET Aspire. We built a system on it and now try to deploy it from github via GitHub Actions to Azure. We did everything as in the instructions and it worked. But One thing started to annoy critically. Every time we deploy the new version - custom domain settings are just gone. The same is about Ingress settings. My changes drop after each release.
Steps to reproduce
Expected behavior
New version is running but previous network and domains settings are the same
Actual behavior
Ingress settings of the app and custom domain settings are dropped.
The text was updated successfully, but these errors were encountered: