Fix linked non-cluster-default blob storage not working for HDI cluster issue #4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezhang
reviewed
Dec 17, 2020
| @@ -90,7 +90,7 @@ public int hashCode() { | |||
| } | |||
|
|
|||
| public String getHadoopBlobFsPropertyKey() { | |||
| return String.format("fs.azure.account.key.%s.blob.%s", getStorageAccount(), getEndpointSuffix()); | |||
| return String.format("spark.hadoop.fs.azure.account.key.%s.blob.%s", getStorageAccount(), getEndpointSuffix()); | |||
There was a problem hiding this comment.
Let's prefix spark.hadoo. at the calling side since it's a Spark definition
There was a problem hiding this comment.
Good suggestion, will make the change in next iteration
| @@ -327,6 +327,14 @@ private Integer parseIntegerSafety(@Nullable Object maybeInteger) { | |||
| return messageList; | |||
| } | |||
|
|
|||
| @JsonIgnore | |||
| public Map<String, Object> updateJobConfig(String key, Object value) { | |||
There was a problem hiding this comment.
I prefer to keep this file minimal changes. We can do it at calling side as below:
submitModel.submissionParameter.getJobConfig().put(SparkSubmissionParameter.Conf, ...)
t-rufang
force-pushed
the
rufan/hdi_link_blob_issue
branch
from
12582bd to
2a7529b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.