Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

port: Added SetSpeakMiddleware to Runtime (#5343) #1080

Closed
github-actions bot opened this issue Mar 24, 2021 · 0 comments · Fixed by #1100
Closed

port: Added SetSpeakMiddleware to Runtime (#5343) #1080

github-actions bot opened this issue Mar 24, 2021 · 0 comments · Fixed by #1100
Assignees
@LeeParrishMSFT
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. P1 Painful if we don't fix, won't block releasing parity The issue describes a gap in parity between two or more platforms. Size: S The issue is simple and well understood, it will take a day or less to complete
Milestone
R13

Comments

@github-actions
Copy link

The changes in Added SetSpeakMiddleware to Runtime (#5343) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5266

The middleware was taken from the previous runtime.

This makes SetSpeakMiddleware available to Runtime via the "features" node in config (as it does for other Runtime supported middleware).

Of special note: I put SetSpeakMiddleware in BotBuilder. But we may want it elsewhere?

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Mar 24, 2021
@cleemullins cleemullins added this to the R13 milestone Mar 24, 2021
@cleemullins cleemullins added Size: S The issue is simple and well understood, it will take a day or less to complete P1 Painful if we don't fix, won't block releasing labels Mar 24, 2021
@LeeParrishMSFT LeeParrishMSFT mentioned this issue Mar 26, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LeeParrishMSFT LeeParrishMSFT

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. P1 Painful if we don't fix, won't block releasing parity The issue describes a gap in parity between two or more platforms. Size: S The issue is simple and well understood, it will take a day or less to complete
Projects
None yet
Milestone
R13
Development

Successfully merging a pull request may close this issue.

Added SetSpeakMiddleware.java and Unit tests microsoft/botbuilder-java
2 participants
@cleemullins @LeeParrishMSFT