Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Single Tenant AppType #2043

Closed
tracyboehrer opened this issue Nov 28, 2023 · 5 comments · Fixed by #2055
Closed

Support Single Tenant AppType #2043

tracyboehrer opened this issue Nov 28, 2023 · 5 comments · Fixed by #2055
Assignees
Labels
feature-request A request for new functionality or an enhancement to an existing one.

Comments

@tracyboehrer
Copy link
Member

tracyboehrer commented Nov 28, 2023

  1. ConfigurationServiceClientCredentialFactory
    • Config.APP_TYPE ("MultiTenant", "SingleTenant", "UserAssignedMsi")
    • Handle Multi or Single tenant
    • Default to MultiTenant if blank
    • Error for UserAssignedMsi (not currently supported in Python MSAL package)
  2. PasswordServiceClientCredentialFactory
    • Match DotNet
  3. AppCredentials (and subclasses)
    • Resolve differences from DotNet
@tracyboehrer tracyboehrer added needs-triage The issue has just been created and it has not been reviewed by the team. feature-request A request for new functionality or an enhancement to an existing one. labels Nov 28, 2023
@jnissin
Copy link

jnissin commented Nov 29, 2023

Just pitching in here that this feature would be highly appreciated. If anyone has any known workarounds for this I'm all ears.

@tracyboehrer
Copy link
Member Author

@tracyboehrer tracyboehrer removed the needs-triage The issue has just been created and it has not been reviewed by the team. label Dec 8, 2023
@tracyboehrer tracyboehrer self-assigned this Dec 8, 2023
@tracyboehrer
Copy link
Member Author

If someone feel adventurous, there is a test version on PyPi for this. Version 0.0.1.

Can use this doc. It hasn't been updated to indicate Pyton support but it works. I did have to update AZ to 2.55.0.

https://learn.microsoft.com/en-us/azure/bot-service/provision-and-publish-a-bot

Attached is the EchoBot sample. It does have modified ARM templates to support SingleTenant. The only other change in the bot is the config.py.

02.echo-bot.zip

@faniereynders
Copy link

This is great @tracyboehrer - thank you! However, it seems like there are conflicts when using it with [email protected] as it depends on [email protected] and [email protected] depends on [email protected]

@faniereynders
Copy link

This is great @tracyboehrer - thank you! However, it seems like there are conflicts when using it with [email protected] as it depends on [email protected] and [email protected] depends on [email protected]

When referencing 0.0.1 for all the bot builder packages it seems to work, but the SSO only seems to work in web channel, in Teams, it is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for new functionality or an enhancement to an existing one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants