Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project.json no longer works #411

Closed
olivd opened this issue May 23, 2017 · 4 comments
Closed

Project.json no longer works #411

olivd opened this issue May 23, 2017 · 4 comments

Comments

@olivd
Copy link

olivd commented May 23, 2017

You created a breaking change and pushed it out as minor release.

Bring back the project.json, down with the csproj

@svick
Copy link
Contributor

svick commented May 23, 2017

You created a breaking change and pushed it out as minor release.

It was not a minor release, it was the first non-preview release of the SDK. The last version of the SDK that supported project.json was Preview 2. csproj is fully supported since SDK 1.0.

Bring back the project.json, down with the csproj

Sorry, that's just not going to happen. If there ever was a possibility to convince Microsoft of this, we're way past that point now. Especially considering that doing it now would actually be a breaking change in released product.

Do you have any specific suggestions about how csproj could be improved?

@olivd
Copy link
Author

olivd commented May 24, 2017

Well thanks for replying. I think it's a little cheeky to say that 1.0.3 was not a production release when you flagged it as a stable long term support release. Anyway. How about making .csproj support both xml and json equivalents ?

@svick
Copy link
Contributor

svick commented May 24, 2017

I think it's a little cheeky to say that 1.0.3 was not a production release when you flagged it as a stable long term support release.

.Net Core 1.0.3 was a stable release, but that's just the runtime, it doesn't contain the project.json tools. .Net Core SDK Preview 2, which actually let you use project.json, was not a stable release. It is kind of confusing that there is a difference between the two, but that's the way it is.

How about making .csproj support both xml and json equivalents?

Does that mean you want JSON, but not necessarily project.json? Then you might be interested in these two issues: dotnet/msbuild#16, dotnet/msbuild#613.

Though the former one was closed with:

We’re strongly considering more concise and expressive markup languages for future build engines. For MSBuild itself, the existing tooling ecosystem (Visual Studio and third-party) is too tied down to the existing XML format. We feel that the risks involved with a change in build-specification representation outweigh the benefits.

@olivd
Copy link
Author

olivd commented May 25, 2017

Okay thanks for that

@olivd olivd closed this as completed May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants