-
Notifications
You must be signed in to change notification settings - Fork 86
Add support for typescript 2.3 #31
Comments
We generally wait until a month after a release before changing any packages on DefinitelyTyped. This gives people time to upgrade to the new TypeScript version before packages start requiring it. |
Thanks for the info @andy-ms |
It's up to you. |
Ok, I'll leave them open and reference this issue. Thanks |
Do we have to have this rule in place across all packages instead of just existing ones? Seems like if a declaration file doesn't exist, there's no reason to keep the restriction in place. |
That would be nice but the way dtslint is designed, it doesn't distinguish between new/changed packages. I guess we could edit types-publisher to just look for the string |
Yes, dtslint just failing on the header is likely confusing to contributors anyway. |
Shouldn't this waiting period be implemented in the type publisher? I can open a related issue on https://github.com/Microsoft/types-publisher if it's more appropriate |
At the moment dtslint does not support the default generic types introduced in typescript 2.3
This causes pr builds to fail on DefinitelyTyped
Example:
DefinitelyTyped/DefinitelyTyped#16196
DefinitelyTyped/DefinitelyTyped#16198
edit: this is not the the only responsible for build fails on DT, but at the moment it fails when testing locally a package with default generic types
The text was updated successfully, but these errors were encountered: