Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rule no-angularjs-sanitization-whitelist #22

Open
tosmolka opened this issue Nov 26, 2021 · 4 comments
Open

Update rule no-angularjs-sanitization-whitelist #22

tosmolka opened this issue Nov 26, 2021 · 4 comments

Comments

@tosmolka
Copy link
Member

Describe the bug

Angular 1.8.1 deprecated $compileProvider.aHrefSanitizationWhitelist and $compileProvider.imgSrcSanitizationWhitelist and replaced them with new methods.

To Reproduce

  1. Inspect source code of the rule
  2. There are no references to aHrefSanitizationTrustedUrlList nor imgSrcSanitizationTrustedUrlList

Expected behavior

Rule is renamed (as per style guide) and supports both old and new method names.

@A-Katopodis
Copy link
Contributor

Hi Tobias,

Thanks for the pointer. We will update it soon and either create a new rule or integrate it into the current one as you suggested

@tosmolka
Copy link
Member Author

Hi @A-Katopodis , do you think this could be fixed by end of Q1 (March 31)? Thanks.

@mkacmar
Copy link
Collaborator

mkacmar commented Oct 3, 2024

We ended up retiring angularjs ruleset in 8f5c28d, closing.

@mkacmar mkacmar closed this as completed Oct 3, 2024
@mkacmar
Copy link
Collaborator

mkacmar commented Oct 4, 2024

angularjs removal was reverted for now, reopening to keep track of this.

@mkacmar mkacmar reopened this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants