diff --git a/change/@fluentui-react-menu-18f45b88-3199-463a-8745-635943d6bccb.json b/change/@fluentui-react-menu-18f45b88-3199-463a-8745-635943d6bccb.json new file mode 100644 index 00000000000000..071f01941934a9 --- /dev/null +++ b/change/@fluentui-react-menu-18f45b88-3199-463a-8745-635943d6bccb.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "fix: remove unwanted aria attributes on context menu", + "packageName": "@fluentui/react-menu", + "email": "bernardo.sunderhus@gmail.com", + "dependentChangeType": "patch" +} diff --git a/packages/react-components/react-menu/src/components/MenuTrigger/MenuTrigger.types.ts b/packages/react-components/react-menu/src/components/MenuTrigger/MenuTrigger.types.ts index dda9513d0226df..c8a78b839648ea 100644 --- a/packages/react-components/react-menu/src/components/MenuTrigger/MenuTrigger.types.ts +++ b/packages/react-components/react-menu/src/components/MenuTrigger/MenuTrigger.types.ts @@ -16,7 +16,7 @@ export type MenuTriggerProps = TriggerProps & { export type MenuTriggerChildProps = ARIAButtonResultProps< Type, Props & { - 'aria-haspopup': 'menu'; + 'aria-haspopup'?: 'menu'; 'aria-expanded'?: boolean; id: string; ref: React.Ref; diff --git a/packages/react-components/react-menu/src/components/MenuTrigger/useMenuTrigger.ts b/packages/react-components/react-menu/src/components/MenuTrigger/useMenuTrigger.ts index e2aadae6578a4b..92397c20d41fe1 100644 --- a/packages/react-components/react-menu/src/components/MenuTrigger/useMenuTrigger.ts +++ b/packages/react-components/react-menu/src/components/MenuTrigger/useMenuTrigger.ts @@ -122,8 +122,6 @@ export const useMenuTrigger_unstable = (props: MenuTriggerProps): MenuTriggerSta }; const contextMenuProps = { - 'aria-haspopup': 'menu', - 'aria-expanded': !open && !isSubmenu ? undefined : open, id: triggerId, ...child?.props, ref: useMergedRefs(triggerRef, child?.ref), @@ -131,13 +129,15 @@ export const useMenuTrigger_unstable = (props: MenuTriggerProps): MenuTriggerSta onMouseLeave: useEventCallback(mergeCallbacks(child?.props.onMouseLeave, onMouseLeave)), onContextMenu: useEventCallback(mergeCallbacks(child?.props.onContextMenu, onContextMenu)), onMouseMove: useEventCallback(mergeCallbacks(child?.props.onMouseMove, onMouseMove)), - } as const; + }; const triggerChildProps = { + 'aria-haspopup': 'menu', + 'aria-expanded': !open && !isSubmenu ? undefined : open, ...contextMenuProps, onClick: useEventCallback(mergeCallbacks(child?.props.onClick, onClick)), onKeyDown: useEventCallback(mergeCallbacks(child?.props.onKeyDown, onKeyDown)), - }; + } as const; const ariaButtonTriggerChildProps = useARIAButtonProps( child?.type === 'button' || child?.type === 'a' ? child.type : 'div',