Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast pass fails for Dropdown Control: Required ARIA child role not present: textbox #17838

Closed
RashmiBal opened this issue Apr 16, 2021 · 4 comments

Comments

@RashmiBal
Copy link

RashmiBal commented Apr 16, 2021

Environment Information

  • Package version(s): "office-ui-fabric-react": "7.166.1"
  • Browser and OS versions: Chrome Win10

Describe the issue:

Ran Accessibility Insights tool on my UI with Dropdown control & got this error locally.
We are using "office-ui-fabric-react": "7.166.1" version.

Actual behavior:

Fast Pass Error Details:
Path
#Dropdown18
Snippet
<div data-is-focusable="true" id="Dropdown18" tabindex="0" role="combobox" aria-haspopup="listbox" aria-expanded="false" aria-label="Modified On From" aria-disabled="false" class="ms-Dropdown dropdown-145">
How to fix
Fix the following:
Required ARIA child role not present: textbox

If I edit HTML in Dev Tools to add role=textbox and title="some title" to this element
<span id="Dropdown18-option" class="ms-Dropdown-title title-146" aria-live="polite" aria-atomic="true">Oldest</span>
it fixes the issue.

DOM created in my application has Error
(For some reason the HTML I pasted as code isnt showing up properly here please see screenshot in the comment)
`


foo

Oldest



`

Expected behavior:

But this error does not repro in your official example that I see on https://developer.microsoft.com/en-us/fluentui#/controls/web/dropdown here is the codepen: https://codepen.io/RV122/pen/WNRyyjZ

DOM created in Official Office Fabric site example does not have Error.
(For some reason the HTML I pasted as code isnt showing up properly here please see screenshot in the comment)
`


Basic uncontrolled example

Select an option



`

Documentation describing expected behavior

@RashmiBal
Copy link
Author

DropdownDOM

@RashmiBal
Copy link
Author

DropdownDOM2

@RashmiBal RashmiBal changed the title Fast pass Fails for Dropdown Control: Required ARIA child role not present: textbox Fast pass fails for Dropdown Control: Required ARIA child role not present: textbox Apr 16, 2021
@khmakoto
Copy link
Member

I can confirm that this is a bug and it should probably be fixed.

CC: @tomi-msft

@tomi-msft
Copy link
Contributor

Hi @RashmiBal, thanks for submitting the issue. After some further research, it looks like this is a false positive on axe-core, the ruleset under accessibility insights. They're working on a fix. See this issue on their repo for more info: dequelabs/axe-core#2505

I would reach out to them for more info. I will go ahead and close this now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants