Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card component in northstar is styled with height:100% #17952

Closed
hund030 opened this issue Apr 26, 2021 · 3 comments
Closed

Card component in northstar is styled with height:100% #17952

hund030 opened this issue Apr 26, 2021 · 3 comments
Assignees
Labels
Component: Card Fluent UI react-northstar (v0) Work related to Fluent UI V0 Needs: Investigation The Shield Dev should investigate this issue and propose a fix Platform: Microsoft Edge Resolution: Soft Close Soft closing inactive issues over a certain period

Comments

@hund030
Copy link

hund030 commented Apr 26, 2021

Environment Information

  • Package version(s): "@fluentui/react-northstar": "^0.54.0",
  • Browser and OS versions: Microsoft Edge Version 90.0.818.41 (Official build) (64-bit),

Please provide a reproduction of the bug in a codepen:

Actual behavior:

Add below codes in my app the Card component is added a class ea by default, which force the card to keep its height with the browser size.

 <Card aria-roledescription="card with avatar, image and action buttons">
          <Card.Header>
            <Skeleton animation="wave">
              <Flex gap="gap.small">
                <Skeleton.Shape round width="32px" height="32px" />
                <div>
                  <Skeleton.Line width="200px" />
                  <Skeleton.Line width="150px" />
                </div>
              </Flex>
            </Skeleton>
          </Card.Header>
        </Card>

image
image
So long it is!
image

Expected behavior:

Expected it looks like what tutorial shows.
image

Priorities and help requested:

Are you willing to submit a PR to fix? No

Requested priority: Low
I can workaround by adding extra css to limit the height, but I hope you can fix it if it's a bug.

@gouttierre
Copy link
Contributor

@hund030 - Thank you for the information to the issue you are experiencing.
@kolaps33 - Would you be able to confirm if this is a regression, or if this behavior is an issue?

@gouttierre gouttierre added Component: Card Needs: Investigation The Shield Dev should investigate this issue and propose a fix Platform: Microsoft Edge and removed Needs: Triage 🔍 labels May 25, 2021
@axhl
Copy link

axhl commented Jun 3, 2021

Any progress on this? I'm experiencing the same height: 100%-issue when using <Card> in 0.56.0 in Chrome. Thank you for investigating.

@andrefcdias andrefcdias mentioned this issue Aug 11, 2021
37 tasks
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Oct 31, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: Card Fluent UI react-northstar (v0) Work related to Fluent UI V0 Needs: Investigation The Shield Dev should investigate this issue and propose a fix Platform: Microsoft Edge Resolution: Soft Close Soft closing inactive issues over a certain period
Projects
None yet
Development

No branches or pull requests

7 participants