Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve perf for typing-related conformance tests #19697

Closed
ecraig12345 opened this issue Sep 8, 2021 · 1 comment
Closed

Improve perf for typing-related conformance tests #19697

ecraig12345 opened this issue Sep 8, 2021 · 1 comment
Labels
Area: Testing Resolution: Soft Close Soft closing inactive issues over a certain period

Comments

@ecraig12345
Copy link
Member

ecraig12345 commented Sep 8, 2021

Some of the tests in react-conformance are related to typings and require parsing the component props using typescript (via react-docgen-typescript).

When this was initially implemented, I tried to cache the TS program across component test files to improve performance. However, this actually didn't work due to the way Jest runs tests (completely isolated between each test file), this actually does nothing.

To increase test performance, we may need to split all typing-based tests into a separate test suite (maybe in its own package) that invokes typing-related tests on all components at once to get rid of the duplicate analysis. I started work on that back when I noticed the issue but unfortunately haven't gotten to finish. Unfinished implementation here.

TS program creation: https://github.com/microsoft/fluentui/blob/master/packages/react-conformance/src/utils/createTsProgram.ts

@ecraig12345 ecraig12345 self-assigned this Sep 8, 2021
@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Feb 5, 2022
@ecraig12345 ecraig12345 reopened this Feb 8, 2022
@microsoft microsoft deleted a comment from msft-fluent-ui-bot Feb 8, 2022
@ecraig12345 ecraig12345 removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Feb 8, 2022
@ecraig12345 ecraig12345 removed their assignment Apr 8, 2022
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Sep 6, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Testing Resolution: Soft Close Soft closing inactive issues over a certain period
Projects
None yet
Development

No branches or pull requests

2 participants