You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the tests in react-conformance are related to typings and require parsing the component props using typescript (via react-docgen-typescript).
When this was initially implemented, I tried to cache the TS program across component test files to improve performance. However, this actually didn't work due to the way Jest runs tests (completely isolated between each test file), this actually does nothing.
To increase test performance, we may need to split all typing-based tests into a separate test suite (maybe in its own package) that invokes typing-related tests on all components at once to get rid of the duplicate analysis. I started work on that back when I noticed the issue but unfortunately haven't gotten to finish. Unfinished implementation here.
Some of the tests in
react-conformance
are related to typings and require parsing the component props using typescript (viareact-docgen-typescript
).When this was initially implemented, I tried to cache the TS program across component test files to improve performance. However, this actually didn't work due to the way Jest runs tests (completely isolated between each test file), this actually does nothing.
To increase test performance, we may need to split all typing-based tests into a separate test suite (maybe in its own package) that invokes typing-related tests on all components at once to get rid of the duplicate analysis. I started work on that back when I noticed the issue but unfortunately haven't gotten to finish. Unfinished implementation here.
TS program creation: https://github.com/microsoft/fluentui/blob/master/packages/react-conformance/src/utils/createTsProgram.ts
The text was updated successfully, but these errors were encountered: