Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChoiceGroup "disabled" prop no longer valid #2290

Closed
OneCyrus opened this issue Jul 24, 2017 · 2 comments
Closed

ChoiceGroup "disabled" prop no longer valid #2290

OneCyrus opened this issue Jul 24, 2017 · 2 comments

Comments

@OneCyrus
Copy link
Contributor

OneCyrus commented Jul 24, 2017

Bug Report

  • Package version(s): 4.21.4
  • Browser and OS versions: all (typscript transpiler error)

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? No

Requested priority: Blocking

Products/sites affected: internal app

Describe the issue:

#1967 broke the ChoiceGroup disabled prop. (may be not. i can't get it to work with older versions as well. probably something to do with an updated typescript version)

[ts] Property 'disabled' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes & Readonly<{ children?: ReactNode; }>...'.

Actual behavior:

"disabled" is no longer a valid prop on IChoiceGroupProps

Expected behavior:

"disabled" is a valid prop on IChoiceGroupProps

@micahgodbolt
Copy link
Member

i believe this is a typescript issue. disabled should always be a valid prop (as it's an HTML prop). Pretty sure we're working on a solution.

@leddie24
Copy link
Collaborator

leddie24 commented Aug 4, 2017

Closing issue, looks like this is solved from #2334

@leddie24 leddie24 closed this as completed Aug 4, 2017
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants