Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: SwatchColorPicker should support overriding just the cell content in Fluent React v8 #28065

Closed
1 task done
pKalaga opened this issue May 31, 2023 · 0 comments
Closed
1 task done
Labels

Comments

@pKalaga
Copy link
Contributor

pKalaga commented May 31, 2023

Library

React / v8 (@fluentui/react)

Describe the feature that you would like added

SwatchColorPicker currently allows overriding the entire buttonCell, which results in the button losing all the default handlers and functionality. The Picker should also allow overriding the content svg which uses fill property and cannot include complex colors like gradients or other color attributes.

Proposal is to add a onRenderCellContent to SwatchColorPickerProps which just overrides the default svg to show cell content.

Have you discussed this feature with our team

No response

Additional context

No response

Validations

  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@github-actions github-actions bot added the Fluent UI react (v8) Issues about @fluentui/react (v8) label May 31, 2023
@pKalaga pKalaga changed the title [Feature]: SwatchColorPicker should support overriding just the cell content [Feature]: SwatchColorPicker should support overriding just the cell content in Fluent React v8 May 31, 2023
@pKalaga pKalaga closed this as completed Jun 7, 2023
@microsoft microsoft locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants