Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Searchbox] defaultValue is never used #4181

Closed
cslecours opened this issue Mar 5, 2018 · 1 comment · Fixed by #4225
Closed

[Searchbox] defaultValue is never used #4181

cslecours opened this issue Mar 5, 2018 · 1 comment · Fixed by #4225
Assignees

Comments

@cslecours
Copy link
Contributor

cslecours commented Mar 5, 2018

Bug Report

  • Package version(s): 5.58.0

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? If the decided outcome is simple to implement.

Requested priority: (Blocking, High, Normal, Low)

Products/sites affected: (if applicable)

Describe the issue:

The prop defaultValue defined in SearchBox.types.ts is never used in SearchBox.base.tsx.

Actual behavior:

Defining defaultValue does nothing.

Expected behavior:

Either defaultValue should be removed from props, or actually do something.

@jordandrako
Copy link
Contributor

I think I will deprecate it until we are ready to implement uncontrolled text fields.

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants