Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming: Props Convention #7005

Closed
JasonGore opened this issue Nov 6, 2018 · 1 comment
Closed

Theming: Props Convention #7005

JasonGore opened this issue Nov 6, 2018 · 1 comment

Comments

@JasonGore
Copy link
Member

JasonGore commented Nov 6, 2018

  • Style Variables vs. Component Variables vs. Props.
  • Variants vs. Types.
    • Should variants be mutually exclusive?
    • Mutually exclusive "type" approach vs. Button experiments separated primary and circular props.
  • What can be themed? All props or only style variables?
    • Fields limits theming to styles, theme and styleVariables currently.
    • Does any solution allow arbitrary props to be themed?
  • Are style variables regular props or a special nested prop?
  • Should we have common prop naming?
  • Should themed props be merged with localized props?
  • content prop vs. slots?
    • Is content always an implied slot?
    • Does the use of content props supercede a more explicitly named slot, such as label?
@JasonGore
Copy link
Member Author

This issue and its questions have been resolved by #7012 and #5721.

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants