Revert "gvfs: add a perf test for reading the index" #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2e88564. This test has been broken since: 5fbe600 t/helper: merge test-read-cache into test-tool and hasn't been needed since: a33fc72 read-cache: force_verify_index_checksum which accomplishes the same goal. Signed-off-by: Ben Peart <[email protected]>
kewillford
approved these changes
Oct 8, 2018
Documentation/config.txt
Outdated
| @@ -974,7 +974,7 @@ core.gvfs:: | |||
| -- | |||
| GVFS_SKIP_SHA_ON_INDEX_READ:: | |||
Remove the gvfs specific test which allowed us to skip the SHA1-1 verification as it has not been needed since master accepted: a33fc72 read-cache: force_verify_index_checksum which accomplishes the same goal. Signed-off-by: Ben Peart <[email protected]>
derrickstolee
added a commit
to microsoft/VFSForGit
that referenced
this pull request
Oct 12, 2018
…racked files Update the package for GitForWindows to include tracing information. Includes the following Git PRs: * [36 Avoid `sane_execvp` in `git rebase` and `git stash`](microsoft/git#36) * [34 Add Trace2 regions to 'pack-objects'](microsoft/git#34) * [28 Trace2 base plus GVFS extensions](microsoft/git#28) * [33 virtualfilesystem: check if directory is included](microsoft/git#33) * [31 Revert "gvfs: add a perf test for reading the index"](microsoft/git#31) * [32 compat/poll: prepare for targeting Windows Vista](microsoft/git#32) * [22 Enable the filesystem cache (fscache) in refresh_index()](microsoft/git#22) * [27 virtualfilesystem: fix bug with symlinks being ignored](microsoft/git#27) * [23 Unpack trees with cache tree gvfs](microsoft/git#23) * [15 virtualfilesystem: don't run the virtual file system hook if the index has been redirected](microsoft/git#15) * Includes Git 2.19.0. This also includes VFS for Git updates from Kevin Willford's work: **Fix missing untracked files when created in subfolder** Add to the test to create multiple level of folders and files in those folder to make sure they show up as untracked files. Update the git for windows version that has the fix. Fixes #358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a stale GVFS specific perf test and removes the GVFS specific optimization to avoid computing the SHA1-1 on index load which is no longer needed.