Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not vendorable #234

Open
elgohr opened this issue Jan 23, 2025 · 0 comments
Open

Not vendorable #234

elgohr opened this issue Jan 23, 2025 · 0 comments

Comments

@elgohr
Copy link

elgohr commented Jan 23, 2025

Describe the bug
At the moment go-mssqldb is vendored as vendor/Microsoft/go-mssqldb (capital M).
The module is named vendor/microsoft/go-mssqldb (minor M).
This will work on MacOS, but not on Linux (as paths are handled case-sensitive, see golang/go#38342).
The capital M seems to come from github.com/Microsoft/go-winio (dependency) as first come first serve.

To Reproduce
Vendor project that includes vendor/Microsoft/go-mssqldb on MacOS and build on Linux.

Expected behavior
Be consistent in module naming and dependencies.
My proposal would be the consistent usage of github.com/microsoft accross modules.
Quick fix could be a replace in context of go-winio (https://go.dev/ref/mod#go-mod-file-replace).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant