Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization packages: CHANGELOG.md and LICENSE files are saving to the root site-packages dir #406

Closed
Pete-rePete opened this issue Nov 12, 2024 · 0 comments · Fixed by #407
Labels
enhancement New feature or request WIP

Comments

@Pete-rePete
Copy link

Pete-rePete commented Nov 12, 2024

Description

As the title says, CHANGELOG.md and LICENSE files are saving to the root site-packages dir. If you install all the serialization packages, these 2 files get overwritten a few times. Then when uninstalling (or running poetry update for that matter) you quickly run into FileNotFoundError errors and poetry telling you Cannot install microsoft-kiota-serialization-text or any of the other ones.

Proposed Solution

  • For license, you don't even need to include it in the include, it gets detected automatically and is included within the package. (here are the files that get included automatically).
  • For changelog you'd need to do a clever hack like this if you really, really want to include it in the python package. I'd recommend just not including changelog in the python package, I can't conceive a reason why the functional code would need it

I made a PR here

Contextual information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WIP
Projects
Archived in project
1 participant