Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the accept header to the request generator method in Ruby #1660

Closed
Tracked by #1049
baywet opened this issue Jun 27, 2022 · 1 comment · Fixed by #1795
Closed
Tracked by #1049

add the accept header to the request generator method in Ruby #1660

baywet opened this issue Jun 27, 2022 · 1 comment · Fixed by #1795
Assignees
Labels
fixed Ruby type:bug A broken experience

Comments

@baywet
Copy link
Member

baywet commented Jun 27, 2022

The request generator method needs to also include the accept header to disambiguate between content types for APIs that do support multiple content types.
More details #1607

@baywet baywet added type:bug A broken experience Ruby labels Jun 27, 2022
@baywet
Copy link
Member Author

baywet commented Aug 17, 2022

Examples
https://github.com/microsoft/kiota-samples/blob/d3f5a537a8bff85bda1f7fe42ba848e99f3646f4/msgraph-mail/dotnet/Users/Item/Messages/MessagesRequestBuilder.cs#L63

writer.WriteLine($"{RequestInfoVarName}.Headers.Add(\"Accept\", \"{string.Join(", ", codeElement.AcceptedResponseTypes)}\");");

@osose-e osose-e linked a pull request Aug 29, 2022 that will close this issue
@baywet baywet changed the title adds the accept header to the request generator method in Ruby add the accept header to the request generator method in Ruby Aug 29, 2022
@ghost ghost added the fixed label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Ruby type:bug A broken experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants