Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate ruby handles multiple indexers endpoints at the same level #1666

Closed
Tracked by #1049
baywet opened this issue Jun 27, 2022 · 0 comments · Fixed by #2110
Closed
Tracked by #1049

validate ruby handles multiple indexers endpoints at the same level #1666

baywet opened this issue Jun 27, 2022 · 0 comments · Fixed by #2110
Assignees
Labels
fixed Ruby type:bug A broken experience
Milestone

Comments

@baywet
Copy link
Member

baywet commented Jun 27, 2022

more information in #1535

Some APIs might index collections by different ids, historically this can be an issue as we end up generating multiple method in the same class with the same name. We should make sure we de-duplicate the methods when needed.

/repos/{owner}/{repo}/commits/{ref}
/repos/{owner}/{repo}/commits/{commit_sha}

Should result in a GetByRef and a GetByCommitSha method which don't conflict with one another.

@baywet baywet added type:bug A broken experience Ruby labels Jun 27, 2022
@baywet baywet added this to the Kiota post-GA milestone Dec 6, 2022
@baywet baywet self-assigned this Dec 23, 2022
@baywet baywet linked a pull request Dec 23, 2022 that will close this issue
@baywet baywet added the fixed label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Ruby type:bug A broken experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants