Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No SymbolKind and CompletionItemKind for traits #158

Closed
felixfbecker opened this issue Jan 15, 2017 · 5 comments
Closed

No SymbolKind and CompletionItemKind for traits #158

felixfbecker opened this issue Jan 15, 2017 · 5 comments
Labels
feature-request Request for new features or functionality

Comments

@felixfbecker
Copy link

felixfbecker commented Jan 15, 2017 •
edited
Loading

https://en.wikipedia.org/wiki/Trait_(computer_programming)

Pretty common in programming languages (see supported languages of that article), for example in PHP: http://php.net/manual/en/language.oop5.traits.php

These cannot currently be represented by a SymbolKind or CompletionItem.
@bruno-medeiros bruno-medeiros mentioned this issue Jan 31, 2017
Closed
@dbaeumer
Copy link
Member

dbaeumer commented Feb 8, 2017

I mark this as a dup of #129.

@dbaeumer dbaeumer closed this as completed Feb 8, 2017
@felixfbecker
Copy link
Author

@dbaeumer I think the discussion #129 moved in the direction of non-extensible symbol kinds and proposals for concrete additions instead - I would rather close #129

@dbaeumer
Copy link
Member

dbaeumer commented Feb 9, 2017

I see your point. Will keep this one open then as well.

@dbaeumer dbaeumer reopened this Feb 9, 2017
@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Apr 12, 2017
@dbaeumer dbaeumer added this to the 4.0 milestone Apr 12, 2017
@ljw1004
Copy link
Contributor

ljw1004 commented Jun 5, 2017

Just posting to add a vote for needing this. (We need it for the Hack language, which derives from PHP.)

@dbaeumer
Copy link
Member

Closing of a dup of #129 again. I will consider this when solving #129.

@dbaeumer dbaeumer removed this from the 4.0 milestone Nov 24, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbaeumer @ljw1004 @felixfbecker