Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for links in diagnostics #926

Closed
dbaeumer opened this issue Feb 18, 2020 · 5 comments
Closed

Add support for links in diagnostics #926

dbaeumer opened this issue Feb 18, 2020 · 5 comments
Labels
feature-request Request for new features or functionality
Milestone
3.16

Comments

@dbaeumer
Copy link
Member

VS Code added API to support links in diagnostics. We should investigate if we adopt this in LSP.
@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Feb 18, 2020
@dbaeumer dbaeumer added this to the 3.16 milestone Feb 18, 2020
@egamma egamma mentioned this issue Feb 18, 2020
Closed
54 tasks
@razzeee
Copy link
Contributor

razzeee commented Feb 18, 2020

I'm currently showing urls via diagnostics, they are just not linked.

@KamasamaK
Copy link
Contributor

Relevant VS Code issue is microsoft/vscode#11847

@owenv owenv mentioned this issue Feb 25, 2020
Merged
@larshp larshp mentioned this issue Mar 11, 2020
Closed
@Krzysztof-Cieslak Krzysztof-Cieslak mentioned this issue Apr 10, 2020
Open
@larshp larshp mentioned this issue Apr 12, 2020
Closed
@dvandra
Copy link

dvandra commented May 26, 2020

Is there any further updates on this feature-request?

@razzeee
Copy link
Contributor

razzeee commented May 26, 2020

I think the current state is it being proposed via microsoft/vscode-languageserver-node@fa9ccc4

https://github.com/microsoft/vscode-languageserver-node#3160-next1-protocol-510-next1-json-rpc-620-next1-client-and-620-next1-server

@dbaeumer
Copy link
Member Author

dbaeumer commented Nov 5, 2020

This got implemented and is documented in the 3.16 spec.

@dbaeumer dbaeumer closed this as completed Nov 5, 2020
@lifeart lifeart mentioned this issue Nov 6, 2020
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
3.16
Development

No branches or pull requests
4 participants
@dbaeumer @razzeee @KamasamaK @dvandra