Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Terminal window doesn't adjust text position after resize #2175

Closed
glnces opened this issue May 30, 2019 · 3 comments
Closed

Shared Terminal window doesn't adjust text position after resize #2175

glnces opened this issue May 30, 2019 · 3 comments
Assignees

Comments

@glnces
Copy link

glnces commented May 30, 2019

Logs:
logs.zip

Product and Version [VS/VSCode]: VSCode 1.34
OS Version [macOS/Windows]: macOS 10.14.5
Live Share Extension Version: 1.0.311

Steps to Reproduce / Scenario:

  1. Start Live Share session
  2. Share Terminal (read/write)
  3. Resize terminal window a few times

Screenshots
Screencast 2019-05-30 at 2 27 45 PM

@Priya91
Copy link

Priya91 commented May 31, 2019

Thanks for reporting the issue. @IlyaBiryukov Can you take a look..

@IlyaBiryukov
Copy link
Collaborator

This is VSCode bug microsoft/vscode#73496

The problem is that they don't fire an event when the terminal height increases. They only fire it on decrease. I'm going to close this issue as external.

@glnces
Copy link
Author

glnces commented May 31, 2019

Thanks! Figured it was live share related since it only happens to me in a shared terminal window, never in a standard terminal window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants