Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabView::Items() is no longer an IObservableVector, is now just an IVector #1021

Closed
DHowett-MSFT opened this issue Jul 9, 2019 · 2 comments
Closed

TabView::Items() is no longer an IObservableVector, is now just an IVector #1021

DHowett-MSFT opened this issue Jul 9, 2019 · 2 comments
Assignees
@teaP
Labels
area-TabView bug Something isn't working team-Controls Issue for the Controls team

Comments

@DHowett-MSFT
Copy link

Describe the bug
In 1c4cbef (#971), TabView changed from being a ListView derivative to containing a ListView. The Items property changed from being an IObservableVector<IInspectable> to just being an IVector<IInspectable>.

This may not be a compatibility concern, but it does make it more difficult to observe the vector changing.

Expected behavior
The Items vector should be observable or TabView could expose an event indicating that the tabs have changed.

Version Info

NuGet package version:
Microsoft.UI.Xaml 2.2.190702001-prerelease
@DHowett-MSFT DHowett-MSFT mentioned this issue Jul 9, 2019
Closed
@jevansaks jevansaks added area-TabView bug Something isn't working labels Jul 9, 2019
@jevansaks
Copy link
Member

Thanks for filing, @DHowett-MSFT!

@DHowett-MSFT DHowett-MSFT mentioned this issue Jul 9, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 13, 2019
Closed
@teaP
Copy link
Contributor

teaP commented Aug 27, 2019

While this is still the case (there are annoying technical reasons) I added TabView.TabItemsChanged which you can listen to, so that should work just as well. Please let me know if there are any problems with that!

@teaP teaP closed this as completed Aug 27, 2019
@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teaP teaP

Labels
area-TabView bug Something isn't working team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DHowett-MSFT @jevansaks @teaP