Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: What is the rationale for default NumberBox.NumberFormatter ? #1798

Closed
tbolon opened this issue Dec 27, 2019 · 1 comment · Fixed by #1894
Closed

Question: What is the rationale for default NumberBox.NumberFormatter ? #1798

tbolon opened this issue Dec 27, 2019 · 1 comment · Fixed by #1894
Assignees
@teaP
Labels
area-NumberBox NumberBox Control question team-Controls Issue for the Controls team

Comments

@tbolon
Copy link

tbolon commented Dec 27, 2019

I have tested the NumberBox control introduced in WinUI 2.3 and was surprised by the default behavior which use English number formatting.

There is a NumberFormatter property which, in my case is set with a mix of french and english settings:
image

I have standard french settings on my computer (only the OS is using english UI text), and the regional settings are set on french (the calculator is using the correct settings).

image

How is this control supposed to work by default ?
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Dec 27, 2019
@ranjeshj
Copy link
Contributor

ranjeshj commented Jan 2, 2020

We should be getting the system number formatter. We could do the same as what calculator is doing here.

@ranjeshj ranjeshj added help wanted Issue ideal for external contributors area-NumberBox NumberBox Control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jan 2, 2020
@StephenLPeters StephenLPeters self-assigned this Jan 2, 2020
@ranjeshj ranjeshj removed the help wanted Issue ideal for external contributors label Jan 2, 2020
@StephenLPeters StephenLPeters removed their assignment Jan 2, 2020
@ranjeshj ranjeshj assigned StephenLPeters and teaP and unassigned StephenLPeters Jan 2, 2020
@teaP teaP mentioned this issue Jan 27, 2020
Merged
@teaP teaP closed this as completed in #1894 Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teaP teaP

Labels
area-NumberBox NumberBox Control question team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes to a few NumberBox issues microsoft/microsoft-ui-xaml
5 participants
@tbolon @StephenLPeters @ranjeshj @teaP @msft-github-bot