Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberBox header and description display issues #1839

Closed
Kinnara opened this issue Jan 14, 2020 · 2 comments · Fixed by #1894
Closed

NumberBox header and description display issues #1839

Kinnara opened this issue Jan 14, 2020 · 2 comments · Fixed by #1894
Assignees
Labels
area-NumberBox NumberBox Control help wanted Issue ideal for external contributors team-Controls Issue for the Controls team

Comments

@Kinnara
Copy link
Contributor

Kinnara commented Jan 14, 2020

Describe the bug

<muxc:NumberBox
    Width="300"
    Header="Header Header Header Header Header"
    Description="Description"
    SpinButtonPlacementMode="Inline" />

image

There are two issues:

  1. The header wraps too early, before reaching the right edge of the control.
  2. The spin buttons are offset when description is used.

I think one way to fix these is to move the header and description content presenters out of the TextBox and into the NumberBox itself.

Expected behavior
image

Version Info

NuGet package version:
Microsoft.UI.Xaml 2.3.191211002

Windows 10 version Saw the problem?
Insider Build (xxxxx)
May 2019 Update (18362) Yes
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jan 14, 2020
@ranjeshj ranjeshj added area-NumberBox NumberBox Control team-Controls Issue for the Controls team labels Jan 14, 2020
@StephenLPeters StephenLPeters added help wanted Issue ideal for external contributors and removed needs-triage Issue needs to be triaged by the area owners labels Jan 15, 2020
@StephenLPeters
Copy link
Contributor

@teaP FYI

@StephenLPeters
Copy link
Contributor

StephenLPeters commented Jan 15, 2020

@SavoySchuler @chigy should the header be wrapping at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NumberBox NumberBox Control help wanted Issue ideal for external contributors team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants