Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentDialog does not respect BorderThickness #2525

Closed
marcelwgn opened this issue May 21, 2020 · 1 comment · Fixed by #2664
Closed

ContentDialog does not respect BorderThickness #2525

marcelwgn opened this issue May 21, 2020 · 1 comment · Fixed by #2664
Labels
area-Dialogs help wanted Issue ideal for external contributors team-Controls Issue for the Controls team

Comments

@marcelwgn
Copy link
Collaborator

Describe the bug

The ContentDialog does not respect BorderThickness, setting the BorderBrush does work however
Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Create ContenDialog with BorderThickness and BorderBrush set to some value

Expected behavior

Both values are respected.
Screenshots

Version Info

WinUI 2.4.2
NuGet package version:

Windows 10 version Saw the problem?
Insider Build (19628) Yes
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop
Mobile
Xbox
Surface Hub
IoT

Additional context

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label May 21, 2020
@MikeHillberg
Copy link
Contributor

A couple of things going on

  • The default ContentDialog control template has a root Grid that sets the BorderThickness to a ThemeResource. It should be TemplateBinding it to the ContentDialog's BorderThickness property, and defaulting that property to the ThemeResource
  • ContentDialog's behavior changes if it's in a tree or not. If it's not in a tree, setting the resource takes effect. If it's in a tree there's some resizing logic that causes it to get ignored.

@ranjeshj ranjeshj added area-Dialogs team-Controls Issue for the Controls team help wanted Issue ideal for external contributors and removed needs-triage Issue needs to be triaged by the area owners labels May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Dialogs help wanted Issue ideal for external contributors team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants