Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A targeted TeachingTip does not get unloaded when its target does #509

Closed
SavoySchuler opened this issue Mar 30, 2019 · 2 comments · Fixed by #1327
Closed

A targeted TeachingTip does not get unloaded when its target does #509

SavoySchuler opened this issue Mar 30, 2019 · 2 comments · Fixed by #1327
Assignees
Labels
area-TeachingTip team-Controls Issue for the Controls team

Comments

@SavoySchuler
Copy link
Member

Describe the bug

A targeted TeachingTip does not get unloaded when its target gets unloaded.

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Add a targeted teaching tip to a page-specific instance of a UI element.
  2. Navigate to that page and prompt the tip to open.
  3. Navigate away from that page.

Expected behavior

I expect the teaching tip to get unloaded when its target gets unloaded.

Actual behavior

The target gets unloaded but the teaching tip remains on-screen.

Screenshots

image xaml controls gallery with a targeted teaching tip on screen that points to nothing

Version Info

NuGet package version:
Microsoft.UI.Xaml 2.1.190319001-prerelease

Windows 10 version Saw the problem?
Insider Build (18865) Yes
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Anniversary Update (14393)
Device form factor Saw the problem?
Desktop Yes
Mobile
Xbox
Surface Hub
IoT

Additional context

@jevansaks
Copy link
Member

Agreed that when the TeachingTip itself gets unloaded we should hide the popup. I'm not sure about watching the target.

@marcelwgn
Copy link
Collaborator

I will fix this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TeachingTip team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants