Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] suggest-details element way off screen in swagger pages #2945

Closed
2 tasks done
kolodny opened this issue Feb 7, 2022 · 2 comments
Closed
2 tasks done

[Bug] suggest-details element way off screen in swagger pages #2945

kolodny opened this issue Feb 7, 2022 · 2 comments
Assignees
Labels

Comments

@kolodny
Copy link

kolodny commented Feb 7, 2022

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Code

No response

Actual Behavior

No response

Expected Behavior

No response

Additional Context

I'm only encountering this issue on swagger ui pages. The easiest way to explain is to go to https://petstore.swagger.io/ and paste this into the devtools to load up a monaco instance:

var script = document.createElement('script');
script.src = 'https://cdnjs.cloudflare.com/ajax/libs/monaco-editor/0.26.1/min/vs/loader.min.js'
document.head.appendChild(script)
await new Promise(r => setTimeout(r, 200))
require.config({ paths: { 'vs': 'https://cdnjs.cloudflare.com/ajax/libs/monaco-editor/0.26.1/min/vs' }});
require(["vs/editor/editor.main"], () => {
  const el = document.createElement('div');
  el.style.height = '400px';
  el.style.width = '50%';
  document.body.appendChild(el)
  monaco.editor.create(el, {
    value: `{
  
}`,
    language: 'json',
    theme: 'vs-dark',
  });
});

If you then try to view the expanded suggestions pane it will render them off screen. To see this I just paste setTimeout(() => {debugger;}, 3000) into the devtools and open up the suggestions:

image

As you can see the suggest-details are positioned offscreen.

image

If we were to remove the position fixed on that container we'd at least see it on screen (but still off of where it should be)

image

@JarvisArt
Copy link

I have the same problem

@jrieken jrieken added the suggest label Dec 6, 2022
@jrieken jrieken added *duplicate Issue identified as a duplicate of another issue(s) and removed *duplicate Issue identified as a duplicate of another issue(s) labels Dec 6, 2023
@jrieken
Copy link
Member

jrieken commented Dec 13, 2023

/duplicate of #3373

@jrieken jrieken closed this as completed Dec 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants