Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

[need to discuss] If experiment's search space doesn't match trial parameters #2668

Closed
Lijiaoa opened this issue Jul 9, 2020 · 1 comment

Comments

@Lijiaoa
Copy link
Contributor

Lijiaoa commented Jul 9, 2020

Environment:

  • NNI version: 1.7
  • NNI mode (local|remote|pai):
  • Client OS:
  • Server OS (for remote mode only):
  • Python version:
  • PyTorch/TensorFlow version:
  • Is conda/virtualenv/venv used?:
  • Is running in Docker?:

Log message:

  • nnimanager.log:
  • dispatcher.log:
  • nnictl stdout and stderr:

What issue meet, what's expected?:

Webui detail page(hyper-parameter) will be broken if experiment's search space doesn't match trial parameters.
And it also affect other function, such as search space type column.

How to do it?:

plan A:

webui check search space and trial parameters key's match status to fix broken page and other items.

advantages:

  • only webui to check these
  • make config.yml laconic

disadvantages:

  • user might give us an unimaginable search space

plan B:

add a field in config.yml file, for example, IsMatchSearchSpaceAndTrialParameter: true. webui could get match status by this field.

advantages:

  • could deal with all tyeps of search space

disadvantages:

  • need to add a field in config.yml (maybe this is a niche demand)

Additional information:

@Lijiaoa
Copy link
Contributor Author

Lijiaoa commented Apr 22, 2021

It has been done on v1.9 by @ultmaster~ so will close this issue now.

@Lijiaoa Lijiaoa closed this as completed Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants