Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Suggest to get rid of netifaces dependency #2895

Closed
liuzhe-lz opened this issue Sep 15, 2020 · 1 comment
Closed

Suggest to get rid of netifaces dependency #2895

liuzhe-lz opened this issue Sep 15, 2020 · 1 comment
Assignees
Labels

Comments

@liuzhe-lz
Copy link
Contributor

liuzhe-lz commented Sep 15, 2020

netifaces is hard to build on Windows. It does not provide wheel for latest Python.
This package is used to get IP address of eth0, which should be simply done by hostname -i. eth0 is not preferred by systemd comparing to "predictable" interface name.
Of course hostname is not supported by Windows, but I believe eth0 will not work either.

I think we should be conservative to introduce binary/native dependencies. They will cause installation problem sooner or later.

@J-shang
Copy link
Contributor

J-shang commented Sep 15, 2020

This does cause some trouble. It ask me to install visual c++ build tools 2016 with 3GB to install netifaces, when I want to install nni on my laptop with clean dev env.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants