Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKLDNN Update #1281

Closed
xkszltl opened this issue Jun 22, 2019 · 8 comments
Closed

MKLDNN Update #1281

xkszltl opened this issue Jun 22, 2019 · 8 comments
Labels
feature request request for unsupported feature or enhancement

Comments

@xkszltl
Copy link
Contributor

xkszltl commented Jun 22, 2019

Describe the bug

FYI MKLDNN 0.19 is out for a while with new version of MKLML, and MKLDNN v0.20 is already in RC

set(MKLDNN_TAG v0.18.1)

@pranavsharma
Copy link
Contributor

pranavsharma commented Jun 22, 2019

Thanks for the update? Have you tested it? How much perf improvement does it show?

@xkszltl
Copy link
Contributor Author

xkszltl commented Jun 22, 2019

No. It's just FYI.

Here's the story about what brings me to this:

I was faking MKLML with full MKL, which works great with native C++.
When we integrate it with .Net, C# tries to check for all symbols at load time, even if it's unused.
And interestingly it found a missing function in the latest version of full MKL (2019 update 4) but exists the version of MKLML used by onnxruntime (2019.0.3.20190220).

@faxu faxu added the feature request request for unsupported feature or enhancement label Jun 24, 2019
@snnn
Copy link
Member

snnn commented Jul 30, 2019

Talked with George, we are planning to do it. @faxu, you may follow up with George.

@peterjc123
Copy link

Any updates for this?

@snnn snnn changed the title MKL Update MKLDNN Update Aug 28, 2019
@snnn
Copy link
Member

snnn commented Aug 28, 2019

We have upgraded MKML. MKLDNN stays the same.

@peterjc123
Copy link

Do you have any plan to update MKLDNN to v0.20.1?

@snnn
Copy link
Member

snnn commented Aug 28, 2019

Sure. It's in progress. Intel is helping us doing the upgrade. @faxu has more details.

@faxu
Copy link
Contributor

faxu commented Oct 11, 2019

Will be addressed by #2102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request request for unsupported feature or enhancement
Projects
None yet
Development

No branches or pull requests

6 participants