Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

paictl will check version alignment when push config #5208

Closed
debuggy opened this issue Dec 28, 2020 · 3 comments · Fixed by #5212
Closed

paictl will check version alignment when push config #5208

debuggy opened this issue Dec 28, 2020 · 3 comments · Fixed by #5212
Assignees
@suiguoxin

Comments

@debuggy
Copy link
Contributor

debuggy commented Dec 28, 2020 •
edited
Loading

What is the function of this behavior? If we want to upgrade the cluster, the version will be always different with current cluster version. So this check might be meaningless.

reproduce step:

  1. current cluster version is 1.5.0
  2. change the version number in /version/PAI.VERSION to 1.4.1
  3. run command ./paictl.py push -p /cluster-configuration -m service
  4. the error log is belowed:

image
@debuggy debuggy mentioned this issue Dec 28, 2020
Closed
52 tasks
@ReyRen
Copy link

ReyRen commented Dec 28, 2020 

Error from server (NotFound): configmaps "pai-version" not found

@suiguoxin
Copy link
Member

@debuggy @ReyRen Yes these logs are confusing. Please ignore them for instance & we'll refine the logging soon.

@suiguoxin
Copy link
Member

suiguoxin commented Dec 29, 2020 •
edited
Loading

Proposals:

  • Remind users to ignore the warning message when upgrade / downgrade / deploy from scratch.
    • pai-version check
    • cluster-id check
  • For get configmap pai-version command, do not print system error log, warning only

@suiguoxin suiguoxin mentioned this issue Dec 29, 2020
Merged
@debuggy debuggy mentioned this issue Jan 4, 2021
Closed
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@suiguoxin suiguoxin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine pai-version / cluster-id checking log suiguoxin/pai
3 participants
@debuggy @suiguoxin @ReyRen