Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wrong webstorm types #15650

Closed
MiguelSOliveira opened this issue Jul 14, 2022 · 4 comments
Closed

[BUG] Wrong webstorm types #15650

MiguelSOliveira opened this issue Jul 14, 2022 · 4 comments

Comments

@MiguelSOliveira
Copy link

Context:

  • Playwright Version: "@playwright/test": "^1.22.0"
  • Operating System: Mac
  • Node.js version: v14.17.0
  • Browser: WebStorm 2022.1.3
## System:
 - OS: macOS 12.4
 - Memory: 907.78 MB / 16.00 GB
## Binaries:
 - Node: 14.17.0 - ~/.nvm/versions/node/v14.17.0/bin/node
 - Yarn: 1.22.11 - ~/atlas/node_modules/.bin/yarn
 - npm: 6.14.13 - ~/.nvm/versions/node/v14.17.0/bin/npm
## Languages:
 - Bash: 3.2.57 - /bin/bash

Describe the bug

Types do not work in webstorm. They work in VSCode.

Could be related: #2268
But I've tried the solutions proposed in that issue without success.

image

image

@yury-s
Copy link
Member

yury-s commented Jul 14, 2022

Looks like the same problem as in #2268 and if I understand it correctly WebStorm will not parse types from playwright-core by default since it is not a direct dependency of your project but a package that @playwright/core depends on. So un-excluding node_modules/playwright-core in WebStorm setting should help, did you try that?

@MiguelSOliveira
Copy link
Author

hi @yury-s it does not seem to be the same. I've installed "playwright-core": "^1.23.3" directly, and the error still persisted.

@yury-s
Copy link
Member

yury-s commented Jul 16, 2022

hi @yury-s it does not seem to be the same.

"So un-excluding node_modules/playwright-core in WebStorm setting should help, did you try that?" - did you try this?

I've installed "playwright-core": "^1.23.3" directly, and the error still persisted.

You should not have playwright-core in your dependencies as @playwright/test will bring it in automatically. Can you share a project where it happens?

@dgozman
Copy link
Contributor

dgozman commented Jul 20, 2022

We have to reproduce this issue locally to be able to debug it. If you can provide a full repro, please file a new issue with it, and link to this one.

@dgozman dgozman closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants