-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]Visual Regression Test screenshots differ from each pipeline run #22620
Comments
Previously had version 1.22.1 version of playwright, everything worked very well, tried updating 1.31.1 and 1.32.3 versions then started getting different results for different runs |
This is known issue; browsers do not have deterministic rendering. You can try experimental comparator that was designed If you do try it, then please let us know how it goes. Thanks! |
The problem with our approach is that, we are comparing the images very strictly without any threshold and other observations are, our test works without any issues from 1.22.0 1.23.0 1.24.0 then issue started coming from 1.25.0 to 1.33.0, there always disturbance in the corners of the component like above screenshots, that too only in Chromium, do we need to set any property or adjust the chromium here? |
@badigerpramod someone reported some success with a bunch of extra flags, however in my experiments they didn't help much. In general, Chromium does not guarantee consistent rendering for the same inputs, so you should be prepared that some pixels might be different. |
@aslushnikov i found solution for the problem, somehow chrome was too fast to run the tests this is where screenshots were wrongly taken/compared, by adding 100ms or required delay before each test solved the issue for me
Now I am getting same results every run! Thank you |
@aslushnikov do you have any references for this? |
System info
Source code
implementing based on https://www.npmjs.com/package/@web/test-runner-visual-regression
The text was updated successfully, but these errors were encountered: