Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files to analyze count is wrong for notebooks #5173

Closed
rchiodo opened this issue Nov 29, 2023 · 2 comments
Closed

Files to analyze count is wrong for notebooks #5173

rchiodo opened this issue Nov 29, 2023 · 2 comments
Assignees
@StellaHuang95
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Nov 29, 2023

  1. Create a notebook with 1000 cells, with each cell having a bunch of imports so it takes a while to analyze
  2. Close VS code
  3. Reopen
  4. Look at the 'Files to Analyze' count = It says 1000s of files to analyze, not 1.
@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Nov 29, 2023
@StellaHuang95 StellaHuang95 added bug Something isn't working and removed needs repro Issue has not been reproduced yet labels Dec 4, 2023
@StellaHuang95 StellaHuang95 mentioned this issue Apr 12, 2024
Closed
@ale-dg ale-dg mentioned this issue Apr 16, 2024
Open
@StellaHuang95
Copy link
Contributor

For now, I plan to update the message to something like xxx files to analyze, xxx cells to analyze, and xxx files and xxx cells to analyze, but it may cause confusion for multiple workspace cases since the status doesn't stack, see https://github.com/microsoft/pyrx/issues/5214. That will be handled in a separate PR.

@StellaHuang95 StellaHuang95 added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label May 22, 2024
@KacieKK
Copy link
Contributor

KacieKK commented May 23, 2024

This issue has been fixed in prerelease version 2024.5.102, which we've just released. You can find the changelog here: CHANGELOG.md

@KacieKK KacieKK closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StellaHuang95 StellaHuang95

Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rchiodo @KacieKK @StellaHuang95