Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 2.0 CppWinRT #2455

Closed
licanhua opened this issue May 10, 2019 · 2 comments
Closed

Support 2.0 CppWinRT #2455

licanhua opened this issue May 10, 2019 · 2 comments
Labels
Code Cleanup nice-to-have p3
Milestone
0.62 (M5)

Comments

@licanhua
Copy link
Contributor

To support this, we migrate/author instance_rt/reactControl_rt/ module_rt in a new way. Here are some details we need to pay attention to:

  • Update CppWinRT nuget from 1.0 to 2.0
  • Remove all term of ABI
  • Remove all Microsoft::WRL::ComPtr and replace then with winrt:: namespace.
  • vcxproj change and target changes. for example, remove midlrt.targets
  • It's possible that we don't need mdmerge target
  • Remove OLD_CPPWINRT
  • Check with other workstream who use make.inc

Some document about cppwinrt
move-to-winrt-from-wrl
author-apis
@licanhua licanhua added the vnext label May 10, 2019
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 10, 2019
@licanhua licanhua mentioned this issue May 10, 2019
Merged
@kmelmon kmelmon added nice-to-have p3 and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels May 14, 2019
@kmelmon
Copy link
Contributor

kmelmon commented May 14, 2019

This would be nice to do but not high in priority. marking as nice-to-have.

@chrisglein chrisglein added this to the vNext Milestone 4 milestone Aug 23, 2019
@licanhua licanhua mentioned this issue Oct 21, 2019
Merged
@licanhua licanhua mentioned this issue Nov 5, 2019
Merged
@licanhua
Copy link
Contributor Author

licanhua commented Nov 7, 2019

The left task is to move WRL to cppwinrt.
Since IModule and other WRL implementation would be moved to other project, I will close this task, and left task is tracking by #3236

@licanhua licanhua closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Cleanup nice-to-have p3
Projects
None yet
Milestone
0.62 (M5)
Development

No branches or pull requests
3 participants
@licanhua @chrisglein @kmelmon