Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewStyleProps border*Color #3077

Closed
6 tasks
chrisglein opened this issue Sep 4, 2019 · 3 comments
Closed
6 tasks

ViewStyleProps border*Color #3077

chrisglein opened this issue Sep 4, 2019 · 3 comments
Labels
API: Completion Area: Borders and Brushes enhancement Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Milestone

Comments

@chrisglein
Copy link
Member

Split out from #2796
https://facebook.github.io/react-native/docs/0.59/view-style-props#borderbottomcolor

  • borderRightColor
  • borderBottomColor
  • borderEndColor
  • borderLeftColor
  • borderStartColor
  • borderTopColor
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Sep 4, 2019
@chrisglein chrisglein added API: Completion Area: Borders and Brushes vnext and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Sep 4, 2019
@chrisglein chrisglein added this to the vNext Milestone 4 milestone Sep 4, 2019
@marlenecota marlenecota changed the title border*Color ViewStyleProps border[Right|Bottom|End|Left|Start|Top]Color Oct 31, 2019
@marlenecota marlenecota changed the title ViewStyleProps border[Right|Bottom|End|Left|Start|Top]Color ViewStyleProps border*Color Oct 31, 2019
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@chrisglein chrisglein modified the milestones: 0.62 (M5), Backlog Apr 9, 2020
@chrisglein chrisglein modified the milestones: Backlog, 0.64 Aug 13, 2020
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Sep 16, 2020
@chrisglein chrisglein added enhancement and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Sep 22, 2020
@chrisglein
Copy link
Member Author

The immediate pressure on this has been relieved, so we may not need this for 0.64. However it's also something that coming from web is just expected. In XAML Border you can have per-side thickness on a border. Which effectively means you can show/hide sides. But you can't specify a different color per side. In order to do that you'd need multiple Border elements or maybe to drop down to Composition in some way to draw multiple parts without creating so many heavy-weight objects.

@rectified95, after coming up with some clever options for grafting borders onto Text where they weren't natively supported 1:1, any thoughts on this one?

@rectified95
Copy link
Contributor

rectified95 commented Sep 24, 2020

Unfortunately, this is a different problem. If XAML doesn't provide the needed properties, then we can't hack our way past it in JS like I did with Text borders.

@chrisglein chrisglein modified the milestones: 0.64, Backlog Sep 25, 2020
@chrisglein chrisglein added the Recommend: Not Planned Recommend that issue should be given Not Planned milestone. label Aug 30, 2023
@chrisglein
Copy link
Member Author

Not something we plan to address on the Paper renderer as we move towards Fabric.
Fabric API completion for 'View' is tracked here: #11136 (and this is completed for Fabric)

@chrisglein chrisglein closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: Completion Area: Borders and Brushes enhancement Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Projects
None yet
Development

No branches or pull requests

3 participants