New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] do DRY in def data_process_with_time in the notebook of examples/00_quick_start/sasrec_amazon.ipynb #1613

Open

miguelgfierro opened this issue Jan 18, 2022 · 0 comments

Assignees

Labels

Collaborator

miguelgfierro commented Jan 18, 2022

Description

The function data_process_with_time is very similar to https://github.com/microsoft/recommenders/blob/60033231b9167438032843c23158c0c776856e0e/recommenders/datasets/split_utils.py#L49

We can refactor

See more details #1530 (comment)

Expected behavior with the suggested feature

Other Comments

miguelgfierro added the enhancement label

miguelgfierro assigned aeroabir

aeroabir mentioned this issue

Update SASRec Notebook & List of Authors #1621

Merged

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment