-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path filter for unit tests #1791
Add path filter for unit tests #1791
Conversation
it seems there are some conflicts. Simon one question, how can we check that this is effective? do you need the code to be in staging or main? for example, if you change a markdown now, are the tests not triggered? |
I forgot you just merged the PR. No wonder all unit tests are triggered. |
@miguelgfierro I know what's going on. As said for the I think the And the path filter action at the job level works as well: |
@simonzhaoms have you tried this code? do you know if it is not triggered if there is a change in a readme? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let's see if this works
Description
This PR adds a path filter to check if any changes to the unit tests code, thus the unit tests will not run if only docs are changed. The paths to trigger the unit tests include (Please confirm @miguelgfierro @pradnyeshjoshi):
Related Issues
Checklist:
staging branch
and not tomain branch
.