-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS/macOS app's TableFeatureSettings.upDownInTable is false by default #1937
Comments
Thanks for reporting. As a workaround, you can explicitly add this feature in your code we initialize ContentEdit plugin. To fix it, would you like to submit a change? Thanks. |
Hi @JiuqingSong, do you know why defaultDisabled is using (!Browser.isChrome && !Browser.isSafari) here? |
@miku1958 I think the only reason is Firefox can work well even without this feature. But it should be fine to also enable it to firefox. |
@JiuqingSong Ok, let me submit a change to remove this line |
Fixes #1941 |
Describe the bug
TableFeatureSettings.upDownInTable only enable for Browser.isChrome or Browser.isSafari
roosterjs/packages/roosterjs-editor-plugins/lib/plugins/ContentEdit/features/tableFeatures.ts
Line 175 in 55b2135
but the up down arrow behavior in iOS/macOS app is also wrong, should it be disable by !Browser.isWebKit?
Tasks
Device Information
The text was updated successfully, but these errors were encountered: