Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS/macOS app's TableFeatureSettings.upDownInTable is false by default #1937

Closed
1 task done
miku1958 opened this issue Jul 10, 2023 · 5 comments
Closed
1 task done

Comments

@miku1958
Copy link
Contributor

miku1958 commented Jul 10, 2023

Describe the bug
TableFeatureSettings.upDownInTable only enable for Browser.isChrome or Browser.isSafari

defaultDisabled: !Browser.isChrome && !Browser.isSafari,

but the up down arrow behavior in iOS/macOS app is also wrong, should it be disable by !Browser.isWebKit?

Tasks

Preview Give feedback

Device Information

  • OS: iOS/macOS
  • Browser: WKWebView
@JiuqingSong
Copy link
Collaborator

Thanks for reporting. As a workaround, you can explicitly add this feature in your code we initialize ContentEdit plugin.

To fix it, would you like to submit a change?

Thanks.

@miku1958
Copy link
Contributor Author

Hi @JiuqingSong, do you know why defaultDisabled is using (!Browser.isChrome && !Browser.isSafari) here?

@JiuqingSong
Copy link
Collaborator

@miku1958 I think the only reason is Firefox can work well even without this feature. But it should be fine to also enable it to firefox.

@miku1958
Copy link
Contributor Author

@JiuqingSong Ok, let me submit a change to remove this line

@miku1958
Copy link
Contributor Author

Fixes #1941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants