From abc21689ffdf526bb01c5d47b964eff0ee1a9391 Mon Sep 17 00:00:00 2001 From: Mark Waddle Date: Thu, 24 Oct 2024 18:45:37 +0000 Subject: [PATCH] Simplify the example guided-conversation definitions Remove redundant resource constraints and update comments to match the code --- .../guided_conversation/definitions/er_triage.py | 10 +++------- .../guided_conversation/definitions/interview.py | 10 +++------- .../definitions/patient_intake.py | 12 ++++-------- .../guided_conversation/definitions/poem_feedback.py | 10 +++------- 4 files changed, 13 insertions(+), 29 deletions(-) diff --git a/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/er_triage.py b/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/er_triage.py index 69335f23..59af6bc6 100644 --- a/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/er_triage.py +++ b/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/er_triage.py @@ -1,6 +1,6 @@ import json -from guided_conversation.utils.resources import ResourceConstraint, ResourceConstraintMode, ResourceConstraintUnit +from guided_conversation.utils.resources import ResourceConstraintMode, ResourceConstraintUnit from pydantic import BaseModel, Field from ..definition import GuidedConversationDefinition @@ -58,7 +58,7 @@ class Artifact(BaseModel): """ # Resource Constraints - Defines the constraints like time for the conversation -resource_constraint = ResourceConstraint( +resource_constraint = GuidedConversationDefinition.ResourceConstraint( quantity=10, unit=ResourceConstraintUnit.MINUTES, mode=ResourceConstraintMode.MAXIMUM, @@ -70,9 +70,5 @@ class Artifact(BaseModel): rules=rules, conversation_flow=conversation_flow, context=context, - resource_constraint=GuidedConversationDefinition.ResourceConstraint( - quantity=10, - unit=ResourceConstraintUnit.MINUTES, - mode=ResourceConstraintMode.MAXIMUM, - ), + resource_constraint=resource_constraint, ) diff --git a/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/interview.py b/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/interview.py index 8a5911ec..a3e14768 100644 --- a/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/interview.py +++ b/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/interview.py @@ -1,6 +1,6 @@ import json -from guided_conversation.utils.resources import ResourceConstraint, ResourceConstraintMode, ResourceConstraintUnit +from guided_conversation.utils.resources import ResourceConstraintMode, ResourceConstraintUnit from pydantic import BaseModel, Field from ..definition import GuidedConversationDefinition @@ -49,7 +49,7 @@ class Artifact(BaseModel): """ # Resource Constraints - Defines time limits for the conversation -resource_constraint = ResourceConstraint( +resource_constraint = GuidedConversationDefinition.ResourceConstraint( quantity=30, unit=ResourceConstraintUnit.MINUTES, mode=ResourceConstraintMode.MAXIMUM, @@ -61,9 +61,5 @@ class Artifact(BaseModel): rules=rules, conversation_flow=conversation_flow, context=context, - resource_constraint=GuidedConversationDefinition.ResourceConstraint( - quantity=30, - unit=ResourceConstraintUnit.MINUTES, - mode=ResourceConstraintMode.MAXIMUM, - ), + resource_constraint=resource_constraint, ) diff --git a/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/patient_intake.py b/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/patient_intake.py index a02d0165..9bd59422 100644 --- a/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/patient_intake.py +++ b/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/patient_intake.py @@ -1,6 +1,6 @@ import json -from guided_conversation.utils.resources import ResourceConstraint, ResourceConstraintMode, ResourceConstraintUnit +from guided_conversation.utils.resources import ResourceConstraintMode, ResourceConstraintUnit from pydantic import BaseModel, Field from ..definition import GuidedConversationDefinition @@ -53,8 +53,8 @@ class PatientIntakeArtifact(BaseModel): # Resource Constraints (optional) - This defines the constraints on the conversation such as time or turns. # It can also help with pacing the conversation, -# For example, here we have set an exact time limit of 10 turns which the agent will try to fill. -resource_constraint = ResourceConstraint( +# For example, here we have set a time limit of 15 minutes which the agent will try to fill. +resource_constraint = GuidedConversationDefinition.ResourceConstraint( quantity=15, unit=ResourceConstraintUnit.MINUTES, mode=ResourceConstraintMode.MAXIMUM, @@ -66,9 +66,5 @@ class PatientIntakeArtifact(BaseModel): rules=rules, conversation_flow=conversation_flow.strip(), context=context.strip(), - resource_constraint=GuidedConversationDefinition.ResourceConstraint( - quantity=15, - unit=ResourceConstraintUnit.MINUTES, - mode=ResourceConstraintMode.MAXIMUM, - ), + resource_constraint=resource_constraint, ) diff --git a/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/poem_feedback.py b/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/poem_feedback.py index d8822ee0..7379bac4 100644 --- a/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/poem_feedback.py +++ b/assistants/guided-conversation-assistant/assistant/agents/guided_conversation/definitions/poem_feedback.py @@ -1,6 +1,6 @@ import json -from guided_conversation.utils.resources import ResourceConstraint, ResourceConstraintMode, ResourceConstraintUnit +from guided_conversation.utils.resources import ResourceConstraintMode, ResourceConstraintUnit from pydantic import BaseModel, Field from ..definition import GuidedConversationDefinition @@ -57,7 +57,7 @@ class ArtifactModel(BaseModel): # Resource Constraints (optional) - This defines the constraints on the conversation such as time or turns. # It can also help with pacing the conversation, # For example, here we have set an exact time limit of 10 turns which the agent will try to fill. -resource_constraint = ResourceConstraint( +resource_constraint = GuidedConversationDefinition.ResourceConstraint( quantity=10, unit=ResourceConstraintUnit.TURNS, mode=ResourceConstraintMode.EXACT, @@ -69,9 +69,5 @@ class ArtifactModel(BaseModel): rules=rules, conversation_flow=conversation_flow.strip(), context=context.strip(), - resource_constraint=GuidedConversationDefinition.ResourceConstraint( - quantity=10, - unit=ResourceConstraintUnit.TURNS, - mode=ResourceConstraintMode.EXACT, - ), + resource_constraint=resource_constraint, )