Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop net5.0 and remove conditions from net8.0 TFM #513

Closed
ViktorHofer opened this issue Aug 30, 2023 · 3 comments
Closed

Drop net5.0 and remove conditions from net8.0 TFM #513

ViktorHofer opened this issue Aug 30, 2023 · 3 comments

Comments

@ViktorHofer
Copy link
Member

net5.0 went out-of-support in May, 2022. Can we remove its TFM and build support?

Also, now that net8.0 is already available as an RC (go-live) release, can we remove the TargetsNet8 conditions?

@jeffkl
Copy link
Collaborator

jeffkl commented Sep 11, 2023

We cannot remove net5.0 support just yet as its needed in case your repository targets .NET 5.0, SlnGen needs to use the exact same SDK to evaluate projects. I don't know exactly when we could remove it and I'm not sure if its adding any overhead honestly.

For .NET 8, yeah now that its RC maybe we could update what SlnGen builds against? It doesn't really matter, as what it does at runtime is find the SDK that you have installed and runs against that. But I'm open to contributions!

@ViktorHofer
Copy link
Member Author

We cannot remove net5.0 support just yet as its needed in case your repository targets .NET 5.0

But .NET 5.0 is already out-of-support for nearly one and a half years. Do we really need to keep support for it alive? Asking as such customers could always consume previous versions of slngen on nuget.org.

@jeffkl
Copy link
Collaborator

jeffkl commented Oct 13, 2023

I've decided to remove support for .NET 3 and .NET 5 in SlnGen 11.x: #537

When .NET 8 is GA, I'll remove the TargetNet8 conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants